|
|
Post by fp00099 on May 6, 2019 15:48:25 GMT
What I am finding is that if 2 of 3 conditions match the ChoiceOption is displayed. I want it to evaluate all three before displaying, what am I missing here?
Condition 1: "InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Workstation_Admin_Tier2,") > 0 Or InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Admin,") > 0
AND
Condition 2: "%XHWManufacturer%" = "HP" Or "%XHWManufacturer%" = "VMware, Inc."
AND
Condition 3: "%ZZIsWorkstationTS%" = "True"
The code looks correct but a second set of eyes is helpful.
…
<Action Type="TSVar" Name="_SMSTSPackageName">"_PP Deploy Windows Server x64 (v4.0)"</Action>
<Action Type="TSVar" Name="ZZIsWorkstationTS" Condition='InStr("%_SMSTSPackageName%","Workstation") > 0'>"True"</Action>
<Action Type="TSVar" Name="ZZIsServerTS" Condition='InStr("%_SMSTSPackageName%","Server") > 0'>"True"</Action>
<Action Type="Input" Name="ClientSetupInput" Title="Client OS" ShowBack="True" ShowCancel="True" Size="Tall" >
<TextInput Prompt="Computer Name" Hint="Enter the name for this system" RegEx=".{3,15}" Variable="ZZComputerName" Question="Name for this system" Default="%OSDComputerName%" />
<CheckBoxInput Variable="DomainJoin" Question="Should this system be domain joined? (Checked = Yes)" CheckedValue="Yes" UncheckedValue="No" Default="Yes" />
<ChoiceInput Variable="ZZOSDImageName" Question="Select the operating system." Required="True" >
<Choice Option="Windows 10 Enterprise, version 1803 (x64)" Value="Win10v1803x64" Condition='InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Workstation_Admin_Tier2,") > 0 And "%XHWManufacturer%" = "HP" Or "%XHWManufacturer%" = "VMware, Inc." And "%ZZIsWorkstationTS%" <> ""' />
<Choice Option="Windows 10 Enterprise, version 1709 (x64)" Value="Win10v1709x64" Condition='InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Workstation_Admin_Tier2,") > 0 Or InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Admin,") > 0 And "%XHWManufacturer%" = "HP" Or "%XHWManufacturer%" = "VMware, Inc." And "%ZZIsWorkstationTS%" = "True"' />
<Choice Option="Windows 7 Enterprise, Service Pack 1 (x64)" Value="Win7SP1x64" Condition='InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Workstation_Admin_Tier2,") > 0 Or InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Admin,") > 0 And "%XHWManufacturer%" = "Hewlett-Packard" Or "%XHWManufacturer%" = "VMware, Inc." And "%ZZIsWorkstationTS%" = "True"' />
</ChoiceInput>
</Action>
…
The evaluation of the condition matches the AD group and Manufacturer however the variable doesn't exist; yet the Choice still appears.
Works (Choice appears)
InStr ("R_SCOR_Admin,R_SCCM_Admin" & ",", "R_SCCM_Workstation_Admin_Tier2,") > 0 Or InStr ("R_SCOR_Admin,R_SCCM_Admin" & ",", "R_SCCM_Admin,") > 0 And "HP" = "HP" Or "HP" = "VMware, Inc." And "" = "True"
Fails (Choice does not appear)
InStr ("R_SCOR_Admin,R_SCCM_Admin" & ",", "R_SCCM_Workstation_Admin_Tier2,") > 0 Or InStr ("R_SCOR_Admin,R_SCCM_Admin" & ",", "R_SCCM_Admin,") > 0 And "Hewlett-Packard" = "HP" Or "HP" = "VMware, Inc." And "" = "True"
|
|
|
|
Post by Jason on May 21, 2019 21:49:29 GMT
There is an order of precedence for logical operators similar to the order of precedence for mathematical functions. You need to group your conditions with parentheses to control this in the same way.
|
|
|
|
Post by chrisc on May 30, 2019 13:43:05 GMT
What I am finding is that if 2 of 3 conditions match the ChoiceOption is displayed. I want it to evaluate all three before displaying, what am I missing here? Condition 1: "InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Workstation_Admin_Tier2,") > 0 Or InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Admin,") > 0 AND Condition 2: "%XHWManufacturer%" = "HP" Or "%XHWManufacturer%" = "VMware, Inc." AND Condition 3: "%ZZIsWorkstationTS%" = "True" The code looks correct but a second set of eyes is helpful. …
<Action Type="TSVar" Name="_SMSTSPackageName">"_PP Deploy Windows Server x64 (v4.0)"</Action>
<Action Type="TSVar" Name="ZZIsWorkstationTS" Condition='InStr("%_SMSTSPackageName%","Workstation") > 0'>"True"</Action>
<Action Type="TSVar" Name="ZZIsServerTS" Condition='InStr("%_SMSTSPackageName%","Server") > 0'>"True"</Action>
<Action Type="Input" Name="ClientSetupInput" Title="Client OS" ShowBack="True" ShowCancel="True" Size="Tall" >
<TextInput Prompt="Computer Name" Hint="Enter the name for this system" RegEx=".{3,15}" Variable="ZZComputerName" Question="Name for this system" Default="%OSDComputerName%" />
<CheckBoxInput Variable="DomainJoin" Question="Should this system be domain joined? (Checked = Yes)" CheckedValue="Yes" UncheckedValue="No" Default="Yes" />
<ChoiceInput Variable="ZZOSDImageName" Question="Select the operating system." Required="True" >
<Choice Option="Windows 10 Enterprise, version 1803 (x64)" Value="Win10v1803x64" Condition='InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Workstation_Admin_Tier2,") > 0 And "%XHWManufacturer%" = "HP" Or "%XHWManufacturer%" = "VMware, Inc." And "%ZZIsWorkstationTS%" <> ""' />
<Choice Option="Windows 10 Enterprise, version 1709 (x64)" Value="Win10v1709x64" Condition='InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Workstation_Admin_Tier2,") > 0 Or InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Admin,") > 0 And "%XHWManufacturer%" = "HP" Or "%XHWManufacturer%" = "VMware, Inc." And "%ZZIsWorkstationTS%" = "True"' />
<Choice Option="Windows 7 Enterprise, Service Pack 1 (x64)" Value="Win7SP1x64" Condition='InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Workstation_Admin_Tier2,") > 0 Or InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Admin,") > 0 And "%XHWManufacturer%" = "Hewlett-Packard" Or "%XHWManufacturer%" = "VMware, Inc." And "%ZZIsWorkstationTS%" = "True"' />
</ChoiceInput>
</Action>
…
The evaluation of the condition matches the AD group and Manufacturer however the variable doesn't exist; yet the Choice still appears. Works (Choice appears)InStr ("R_SCOR_Admin,R_SCCM_Admin" & ",", "R_SCCM_Workstation_Admin_Tier2,") > 0 Or InStr ("R_SCOR_Admin,R_SCCM_Admin" & ",", "R_SCCM_Admin,") > 0 And " HP" = "HP" Or "HP" = "VMware, Inc." And "" = "True"Fails (Choice does not appear)InStr ("R_SCOR_Admin,R_SCCM_Admin" & ",", "R_SCCM_Workstation_Admin_Tier2,") > 0 Or InStr ("R_SCOR_Admin,R_SCCM_Admin" & ",", "R_SCCM_Admin,") > 0 And "Hewlett-Packard" = "HP" Or "HP" = "VMware, Inc." And "" = "True"Did you get this working? Can you link the code? |
|
|
|
Post by fp00099 on Jun 14, 2019 14:18:02 GMT
I did eventually get this working, and I simply created different variables and used that.
<Action Type="TSVar" Name="ZZIsWorkstationTS" Condition='InStr("%_SMSTSPackageName%","Workstation") > 0'>"True"</Action>
<Action Type="TSVar" Name="ZZIsServerTS" Condition='InStr("%_SMSTSPackageName%","Server") > 0'>"True"</Action>
<Action Type="TSVar" Name="ZZIsWorkstationIPUTS" Condition='InStr("%_SMSTSPackageName%","Upgrade to Windows 10") > 0'>"True"</Action>
<Action Type="TSVar" Name="ZZIsServerIPUTS" Condition='InStr("%_SMSTSPackageName%","Upgrade to Windows Server") > 0'>"True"</Action>
<Action Type="TSVar" Name="ZZSupportedManufacturers" Condition='"%XHWManufacturer%" = "HP" Or "%XHWManufacturer%" = "Hewlett-Packard" Or "%XHWManufacturer%" = "VMware, Inc." Or "%XHWManufacturer%" = "Microsoft"'>"True"</Action>
<Action Type="TSVar" Name="ZZSupportedTPMManufacturers" Condition='"%XHWManufacturer%" = "HP" Or "%XHWManufacturer%" = "Hewlett-Packard" Or "%XHWManufacturer%" = "Microsoft"'>"True"</Action>
<Action Type="TSVar" Name="ZZSupportedLegacyModels" Condition='"%XHWModel%" = "HP EliteBook Folio 9470m" Or "%XHWModel%" = "HP EliteBook Folio 9480m" Or "%XHWManufacturer%" = "VMware, Inc."'>"True"</Action>
<Action Type="TSVar" Name="ZZSupportedServerModels" Condition='"%XHWModel%" = "HP ProLiant DL380 G9" Or "%XHWModel%" = "HP ProLiant DL380 G10" Or "%XHWManufacturer%" = "VMware, Inc."'>"True"</Action>
<Action Type="TSVar" Name="ZZAuthorizedWorkstationAdmins" Condition='InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Workstation_Admin_Tier1,") > 0 Or InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Admin,") > 0 Or InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Regional_SMEs,") > 0'>"True"</Action>
<Action Type="TSVar" Name="ZZAuthorizedServerAdmins" Condition='InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Server_Admin_Tier1,") > 0 Or InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Admin,") > 0 Or InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Regional_SMEs,") > 0'>"True"</Action>
Since I need to check hardware and group membership I used the following.
<ChoiceInput Variable="ZZOSDImageName" Question="Select the operating system." Required="True" >
<Choice Option="Windows Server 2012 R2 Datacenter (x64)" Value="WS2012R2DCx64" Condition='"%ZZAuthorizedServerAdmins%" = "True" And "%ZZSupportedServerModels%" = "True" And "%ZZIsServerTS%" = "True"' />
<Choice Option="Windows Server 2012 R2 Standard (x64)" Value="WS2012R2STDx64" Condition='"%ZZAuthorizedServerAdmins%" = "True" And "%ZZSupportedServerModels%" = "True" And "%ZZIsServerTS%" = "True"' />
<Choice Option="Windows Server 2016 Datacenter (x64)" Value="WS2016DCx64" Condition='"%ZZAuthorizedServerAdmins%" = "True" And "%ZZSupportedServerModels%" = "True" And "%ZZIsServerTS%" = "True"' />
<Choice Option="Windows Server 2016 Standard (x64)" Value="WS2016STDx64" Condition='"%ZZAuthorizedServerAdmins%" = "True" And "%ZZSupportedServerModels%" = "True" And "%ZZIsServerTS%" = "True"' />
<Choice Option="Windows Server 2019 Datacenter (x64)" Value="WS2019DCx64" Condition='"%ZZAuthorizedServerAdmins%" = "True" And "%ZZSupportedServerModels%" = "True" And "%ZZIsServerTS%" = "True"' />
<Choice Option="Windows Server 2019 Standard (x64)" Value="WS2019STDx64" Condition='"%ZZAuthorizedServerAdmins%" = "True" And "%ZZSupportedServerModels%" = "True" And "%ZZIsServerTS%" = "True"' />
<Choice Option="Windows 10 Enterprise, version 1910 (x64)" Value="Win10v1910x64" Condition='"%ZZAuthorizedWorkstationAdmins%" = "True" And "%ZZSupportedManufacturers%" = "True" And "%ZZIsWorkstationTS%" = "True" And InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_PreProd_OS,") > 0' />
<Choice Option="Windows 10 Enterprise, version 1803 (x64)" Value="Win10v1803x64" Condition='"%ZZAuthorizedWorkstationAdmins%" = "True" And "%ZZSupportedManufacturers%" = "True" And "%ZZIsWorkstationTS%" = "True"' />
<Choice Option="Windows 10 Enterprise, version 1709 (x64)" Value="Win10v1709x64" Condition='"%ZZAuthorizedWorkstationAdmins%" = "True" And "%ZZSupportedLegacyModels%" = "True" And "%ZZIsWorkstationTS%" = "True"' />
<Choice Option="Windows 7 Enterprise, Service Pack 1 (x64)" Value="Win7SP1x64" Condition='"%ZZAuthorizedWorkstationAdmins%" = "True" And "%ZZSupportedManufacturers%" = "True" And "%ZZIsWorkstationTS%" = "True" And InStr ("%XAuthenticatedUserGroups%" & ",", "R_SCCM_Legacy_OS,") > 0' />
</ChoiceInput>
|
|
